Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104018: remove unused format "z" handling in string formatfloat() #104107

Merged
merged 1 commit into from
May 7, 2023
Merged

gh-104018: remove unused format "z" handling in string formatfloat() #104107

merged 1 commit into from
May 7, 2023

Conversation

belm0
Copy link
Contributor

@belm0 belm0 commented May 2, 2023 •
edited by bedevere-bot
Loading

This is a cleanup overlooked in PR #104033.

Please skip NEWS.

@bedevere-bot bedevere-bot mentioned this pull request May 2, 2023
Closed
@belm0 belm0 changed the title gh-104018: remove unused format "z" handling in string objects gh-104018: remove unused format "z" handling in string formatfloat() May 2, 2023
@belm0 belm0 marked this pull request as draft May 2, 2023 22:15
@belm0
pythongh-104018: remove unused format "z" handling in string formatfl…
a3be962 
…oat()

This is a cleanup overlooked in PR python#104033.

Please skip NEWS.
@belm0 belm0 force-pushed the z_format_object_cleanup branch from 35ba4e4 to a3be962 Compare May 2, 2023 22:23
@belm0 belm0 marked this pull request as ready for review May 2, 2023 22:23
@belm0 belm0 requested a review from isidentical as a code owner May 2, 2023 22:23
@arhadthedev arhadthedev added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes labels May 3, 2023
mdickinson
mdickinson approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@kumaraditya303 kumaraditya303 merged commit 69621d1 into python:main May 7, 2023
@miss-islington
Copy link
Contributor

Thanks @belm0 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104260 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2023
@belm0 @miss-islington
pythongh-104018: remove unused format "z" handling in string formatfl…
eea8edc 
…oat() (pythonGH-104107)

This is a cleanup overlooked in PR pythonGH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@miss-islington @belm0
[3.11] gh-104018: remove unused format "z" handling in string formatf…
15ffcf7 
…loat() (GH-104107) (#104260)

gh-104018: remove unused format "z" handling in string formatfloat() (GH-104107)

This is a cleanup overlooked in PR GH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
@belm0 belm0 deleted the z_format_object_cleanup branch May 7, 2023 10:50
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this pull request May 8, 2023
@belm0 @jbower-fb
pythongh-104018: remove unused format "z" handling in string formatfl…
06707b9 
…oat() (python#104107)

This is a cleanup overlooked in PR python#104033.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@belm0 @miss-islington @bedevere-bot @mdickinson @kumaraditya303 @arhadthedev